Require explicit acknowledgement for risky Rust call analysis#2715
Open
sumitshahorg wants to merge 1 commit intogoogle:mainfrom
Open
Require explicit acknowledgement for risky Rust call analysis#2715sumitshahorg wants to merge 1 commit intogoogle:mainfrom
sumitshahorg wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add --allow-risky-rust-call-analysis and fail fast when --call-analysis=rust is enabled without explicit trust acknowledgement. Also add README warning and a small explanatory comment near the guard.
464c7ab to
7d8b3a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a safety guard for Rust call analysis to prevent unintended execution of untrusted code during scanning, explicitly addressing a Remote Code Execution (RCE) risk.
Problem
When
--call-analysis=rustis enabled, the scanner invokescargo build, which executesbuild.rsscripts. These scripts can contain arbitrary code and are executed automatically during the build process.This creates a Remote Code Execution (RCE) risk where scanning an untrusted project can lead to arbitrary code execution on the host system without explicit user awareness.
Solution
--allow-risky-rust-call-analysisbuild.rsBehavior Change
Before:
After:
Security Impact
build.rsNotes
This change does not alter functionality when explicitly enabled, but enforces a secure default by requiring user acknowledgement before executing potentially unsafe build steps.